Hi all,

first thing: The content templater is a very, very usefull addon I really like!

I tried to send this posting with the nonumber-contact-form but had no luck. ("you are not allowed to use this form" or similar...)

What I wanted to say: The templater has a major performance problem that would be easy to fix. I patched one model and got no problem any more. I thought, you nonumbers are possibly interested...

Following is written by memory - details may differ, the main thing should be clear.

The model coded in models/item.php utilizes a JParamter object that loads some xml data from a file on disk. Loading the file takes (on my testing system) about 0,03 seconds.

In a site with two jce-editor instances and a lot of templates, I count about 200 file accesses that cumulate to about 6 seconds. Another site takes more than 10 seconds just for opening the same file several hundred times. That's bad.

I patched the model in a simple way: Using a small factory class like the one in [1], and replaced following line in item.php:


=>


After this modification, the templater works fast as hell.

Greets, Clemente

[1]

I don't see why this would improve performance.
Every time the $xml is created it is unique (different values).
So I don't understand why creating instances would be beneficial.

I have done some testing with your code and it actually uses up more php memory than the original (page load is a little faster, though).

HI,

Every time the $xml is created it is unique (different values).
This is not what I observe
I just put following line in line 134 of item.php. Just before the $xml = new JParameter... stuff.


The output generated is here: http://pastie.org/823008.
Every line there opens the following and obviously identical File:


You can count the lines and multiply your result with about 0.03 seconds...

What I suggest is:
Create only one instance of JParameter and consequently open the file only one time.

If running in debug mode, Joomla says following:
Time until reneered unpatched: About 6 seconds.
Time until rendered patches: 0,8 seconds.

As already written: The issue has only impact with a lot of templates active. In this situation, we use about 40 templates.

and it actually uses up more php memory
I didn't profile this - but I cannot believe that 1 instance can afford more memory than 200 instances of a class. Perhaps you did something wrong? I copy/paste my code below.

Somewhere out of the model class, best below. Starting at line 485:


Lines 133 and 134:

Hi again,

I just opened the same site unpatched and patched to see the memory usage. Joomla was in debug mode, results are copy/pasted direct from the html ouput.
Those number sprek for themselves - little less memory usage and less than 10% rendering time after patching...

Unpatched:
Profil zum Laufzeitverhalten
Application afterLoad: 0.002 seconds, 0.42 MB
Application afterInitialise: 0.135 seconds, 3.55 MB
Application afterRoute: 0.135 seconds, 3.55 MB
Application afterDispatch: 11.366 seconds, 7.87 MB
Application afterRender: 11.471 seconds, 8.88 MB
Speichernutzung
9358720

Patched:
Profil zum Laufzeitverhalten
Application afterLoad: 0.002 seconds, 0.43 MB
Application afterInitialise: 0.099 seconds, 3.55 MB
Application afterRoute: 0.099 seconds, 3.55 MB
Application afterDispatch: 0.812 seconds, 7.72 MB
Application afterRender: 0.924 seconds, 8.72 MB
Speichernutzung
9186620

I didn't say the xml file is unique. I said the $xml var is unique.
The params is unique (in your function, the $ini). So what is returned to the $xml var is unique.

I'll do some more testing.